Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_library_dirs -> _library_dirs_suffix #179

Merged
merged 1 commit into from
Jul 17, 2019
Merged

_library_dirs -> _library_dirs_suffix #179

merged 1 commit into from
Jul 17, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jul 17, 2019

This looks like a typo. ament_export_library_names() is a macro so the variable _library_dirs_suffix could come from elsewhere, but grep did not show any other instances in ament_cmake

@sloretz
_library_dirs -> _library_dirs_suffix
f66362b 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added bug Something isn't working in review Waiting for review (Kanban column) labels Jul 17, 2019
@sloretz sloretz requested a review from dirk-thomas July 17, 2019 00:06
@sloretz sloretz self-assigned this Jul 17, 2019
dirk-thomas
dirk-thomas approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is there a use case where you noticed this which is broken atm?

@sloretz
Copy link
Contributor Author

sloretz commented Jul 17, 2019

@dirk-thomas no use case; just something I noticed while looking at ros/class_loader#129

@sloretz
Copy link
Contributor Author

sloretz commented Jul 17, 2019

CI (testing rcl)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 604c2e7 into master Jul 17, 2019
@sloretz sloretz deleted the sloretz/fix-library-dirs-suffix-typo branch July 17, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@sloretz sloretz

Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @dirk-thomas