Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use deterministic order for updated env vars #196

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

dirk-thomas
Copy link
Contributor

Cosmetic improvement.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Aug 29, 2019
@dirk-thomas dirk-thomas self-assigned this Aug 29, 2019
@dirk-thomas dirk-thomas merged commit 95cab1d into master Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/deterministic-order-env branch September 4, 2019 16:56
nuclearsandwich pushed a commit that referenced this pull request Mar 20, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
nuclearsandwich pushed a commit that referenced this pull request Mar 23, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
nuclearsandwich added a commit that referenced this pull request Apr 11, 2020
* Add runner option to ament_add_test (#174)

* ament_cmake allow speficiation of a different test runner

  - By default, still uses run_test.py
  - Example use case: ament_cmake_ros can use a test runner that
    sets a ROS_DOMAIN_ID

Signed-off-by: Pete Baughman <pete.baughman@apex.ai>

* ament_cmake move run_test.py to a python module

  - This should let us see the history

Signed-off-by: Pete Baughman <pete.baughman@apex.ai>

* ament_cmake refactor run_test.py into an importable python module

  - Adds an ament_cmake_test python package

Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* improve handling of encoding (#181)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* use deterministic order for updated env vars (#196)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* Run tests in current binary directory, not global source directory (#206)

Switch to CMAKE_CURRENT_BINARY_DIR for consistency with CTest

Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* remove status attribute from result XML, add skipped tag instead (#218)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* Declare AMENT_TEST_RESULTS_DIR as a PATH (#221)

Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* Generate xunit files valid for the junit10.xsd

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* Revert "Run tests in current binary directory, not global source directory (#206)"

This reverts commit 4354d62.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

Co-authored-by: Peter Baughman <dblue135@yahoo.com>
Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Co-authored-by: Dan Rose <rotu@users.noreply.github.com>
Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants