consider exported interfaces in ament_target_dependencies #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/export-interfaces
branch
from
6103781
to
0b172fe
Compare
This was referenced Mar 28, 2020
|
Related to ros2/ros2#904. |
j-rivero
pushed a commit
that referenced
this pull request
Apr 27, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow packages to export targets instead of include directories / libraries. And as long as downstream packages are using
ament_target_dependenciesthe change will be transparent.CI builds (without retrying flaky tests) - including the changes from #231: