Drop duplicated <skipped/> element in result file #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <skipped/> element was actually added as part of the `skipped_message` several lines earlier. While multiple <skipped/> elements doesn't violate the JUnit schema, there is no reason to have more than one. Signed-off-by: Scott K Logan <logans@cottsay.net>
dirk-thomas
approved these changes
Apr 17, 2020
j-rivero
pushed a commit
that referenced
this pull request
Apr 27, 2020
The `<skipped/>` element was actually added as part of the `skipped_message` several lines earlier. While multiple `<skipped/>` elements doesn't violate the JUnit schema, there is no reason to have more than one. Signed-off-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element was actually added as part of the
skipped_messageseveral lines earlier.While multiple elements doesn't violate the JUnit schema, there is no reason to have more than one.
Follow-up to #218