redo use _TARGETS over deprecated _INTERFACES over classic CMake variables #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
dirk-thomas/use-targets-over-interfaces-over-classic-vars-2
branch
from
bc2d832
to
f459e00
Compare
hidmic
approved these changes
Apr 27, 2020
ament_cmake_export_dependencies/cmake/ament_cmake_export_dependencies-extras.cmake.in
Outdated
Show resolved
Hide resolved
| message(DEPRECATION | ||
| "Package ${package_name} is exporting the variable " | ||
| "${package_name}_INTERFACES which is deprecated, it should export | ||
| ${package_name}_TARGETS instead") |
There was a problem hiding this comment.
@dirk-thomas we need an issue to follow-up with this deprecation once Foxy is out.
|
Full CI builds:
Full CI builds (without this PR but all other PRs related to modern CMake):
So I will go ahead and merge the other PRs but keep looking into why this one has a problem on Windows. |
|
The latest commit fixes the Windows build: |
This was referenced Apr 28, 2020
…ables Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/use-targets-over-interfaces-over-classic-vars-2
branch
from
7a2d7fb
to
bd530eb
Compare
|
CI builds without tests:
Windows build testing |
wjwwood
approved these changes
Apr 30, 2020
|
Hopefully this second time the merge is more successful 🤞 |
delete-merged-branch
bot
deleted the
dirk-thomas/use-targets-over-interfaces-over-classic-vars-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #249. Related to ros2/ros2#904.