[ament_cmake_gtest] ensure gtest to consume the correct headers. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seanyen <seanyen@microsoft.com>
seanyen
force-pushed
the
seanyen/googletest
branch
from
d2ad75d
to
bd1f2b6
Compare
Signed-off-by: seanyen <seanyen@microsoft.com>
seanyen
force-pushed
the
seanyen/googletest
branch
from
44c8eb0
to
dc7da4b
Compare
|
Just to be safe - the patch shouldn't affect our standard builds. CI build only running CTest tests (except linters):
|
|
Thanks for the review and merge! |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 6, 2020
* ensure gtest to consume the correct headers. Signed-off-by: seanyen <seanyen@microsoft.com> * add another patch. Signed-off-by: seanyen <seanyen@microsoft.com>
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 7, 2020
* ensure gtest to consume the correct headers. Signed-off-by: seanyen <seanyen@microsoft.com> * add another patch. Signed-off-by: seanyen <seanyen@microsoft.com> Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
added a commit
that referenced
this pull request
Aug 7, 2020
… (#268) * ensure gtest to consume the correct headers. Signed-off-by: seanyen <seanyen@microsoft.com> * add another patch. Signed-off-by: seanyen <seanyen@microsoft.com> Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Sean Yen <seanyen@microsoft.com>
seanyen
added a commit
to ms-iot/ament_cmake
that referenced
this pull request
Sep 16, 2020
…nt#267) * ensure gtest to consume the correct headers. Signed-off-by: seanyen <seanyen@microsoft.com> * add another patch. Signed-off-by: seanyen <seanyen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building
ROS2from source onWindows, if there is another copy ofgtestin theCMAKE_PREFIX_PATH, theament_cmake_gtestcould consume the wrong headers and causes build breaks.Here is a snapshot of what errors you might see:
This pull request is to ensure the
gtestandgtest_mainto consume the respective headers.