fix cmake list(TRANSFORM ) is only available from version 3.12, #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Oct 27, 2020
ament_cmake_export_dependencies/cmake/ament_cmake_export_dependencies-extras.cmake.in
Show resolved
Hide resolved
convert to string instead Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com>
|
Thank you for the fix. |
hidmic
pushed a commit
that referenced
this pull request
Apr 12, 2021
…cmake (#290) (#296) (#331) * fix imported targets with multiple configuration (#290) * fix imported targets with multiple configuration Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com> * taking into account DEBUG_CONFIGURATIONS global variable Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix cmake list(TRANSFORM ) is only available from version 3.12, (#296) convert to string instead Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: siposcsaba89 <siposcsaba89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sorry for the inconvenience, I should have checked the minimum required cmake version before sending the pull request #290. Because ament cmake required version is 3.5, and list(TRANSFORM ) not available below version 3.12, I fixed the compatibility issue by using string(TOUPPER ) and foreach instead of list(TRANSFORM).
Sorry again,
BR
Csaba