Fix ament_target_dependencies
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
First, I'm sorry for the very long delay in looking into this.
Second, thank you so much for the detailed bug report and analysis in #451 .
Finally, this fix looks good to me, so I'm going to go ahead and run CI on it. Assuming that comes back green I'll go ahead and merge.
CMake `find_library` does not do anything if the input variable is already set. Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake
find_librarydoes not do anything if the input variable is already set.For example
ament_target_dependenciesdoes not work properly with PCL.See #451