Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings related to gtest/gmock (#408) #495

Conversation

atzaros
Copy link

@atzaros atzaros commented Nov 24, 2023

Closes #494

  • Suppress compiler warnings when building gmock

definition of implicit copy constructor ... is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]

  • Declare gtest/gmock include dirs as SYSTEM PRIVATE for test targets

* Suppress compiler warnings when building gmock

definition of implicit copy constructor ... is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]

* Declare gtest/gmock include dirs as SYSTEM PRIVATE for test targets

Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Signed-off-by: atzaros <128592691+atzaros@users.noreply.github.com>
@atzaros atzaros force-pushed the fix-compiler-gtest-gmock-warnings-backport-408 branch from eb93883 to dbe21ba Compare November 24, 2023 13:28
@atzaros
Copy link
Author

atzaros commented Dec 1, 2023

@clalancette Is it possible to accept this backport to humble?

thanks

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 960b8e8 into ament:humble Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants