Fix failure in config file installed by ament_cmake_export_dependencies when using more than one build type

[ivanpauno]

Fixes #262.

I'm not sure what we should do if the current configuration doesn't match any of the imported configurations.
Should IMPORTED_IMPLIB and IMPORTED_LOCATION be used in that case instead of the config specific ones?
Should one config be picked randomly from the imported configs?

[ivanpauno]

This seem to not be the right approach. I got a link error when building lifecycle, likely related to this change in my local workspace.

[dirk-thomas]

This seem to not be the right approach. I got a link error when building lifecycle, likely related to this change in my local workspace.

Does it actually enter the if block if("$<CONFIG>" IN_LIST _imported_configurations) when it fails to link or does is the condition FALSE and therefore doesn't link against anything from that target?

[ivanpauno]

Does it actually enter the if block if("$" IN_LIST _imported_configurations) when it fails to link or does is the condition FALSE and therefore doesn't link against anything from that target?

Good point, generators expressions can't be used everywhere.
13fada7 fixes that, though I'm still unsure if this is the right approach.

[ivanpauno]

it seems that generator expressions can't be used in get_target_property either, so $<CONFIG> is not being solved correctly 😕

[hidmic]

@ivanpauno is this still a valid PR?

[siposcsaba89]

@ivanpauno is this still a valid PR?

Hi everyone,

I just run into the same issue, when compiling ros2 on windows against libraries built with vcpkg, I wanted to also report the issue then I saw this PR, my solution is a little bit different: https://github.com/siposcsaba89/ament_cmake/commit/d36265934f022f97e674311dcb0039ed8c26b2e6

Thanks,
Csaba

[ivanpauno]

@ivanpauno is this still a valid PR?

The PR tries to fix something that's still an issue, I was blocked on this comment and didn't find a way to workaround that problem.

I just run into the same issue, when compiling ros2 on windows against libraries built with vcpkg, I wanted to also report the issue then I saw this PR, my solution is a little bit different: siposcsaba89@d362659

Hi @siposcsaba89, your patch sounds reasonable to me, can you open a PR?

[siposcsaba89]

@ivanpauno is this still a valid PR?

The PR tries to fix something that's still an issue, I was blocked on this comment and didn't find a way to workaround that problem.

I just run into the same issue, when compiling ros2 on windows against libraries built with vcpkg, I wanted to also report the issue then I saw this PR, my solution is a little bit different: siposcsaba89/ament_cmake@d362659

Hi @siposcsaba89, your patch sounds reasonable to me, can you open a PR?

Hi @ivanpauno ,

Of course, here it is #290

BR,
Csaba