-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor paths to use rcpputils filesystem helper #46
Conversation
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some trivial feedback on include statement order, lgtm.
I don't think there's any issue with adding rcpputils
as a dependency of ament_index_cpp
.
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
@wjwwood nits resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Looks like a compiler error on Windows:
|
Can I stop the rest of the CI since windows failed? |
Yeah, feel free to do that. |
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
@wjwwood it looks like the builds are unstable due to an unrelated issue (flake8/copyright). Should I re-run CI? |
Not yet, I'm looking into it. |
@piraka9011 can you rerun? I think we've reverted the offending change. |
Re-running my CI from several comments above (not sure if the settings are similar to @piraka9011's): |
They are the same. I wanted to run the CI at the end of the day since it's a lot of packages and I didn't want to hog the queue. |
Ok, no worries, that was thoughtful of you, but I already started them, so we'll just let them run. |
For reasons I don't fully understand, it looks like this PR broke the packaging jobs on Linux. For instance, if you download any packaging job from https://ci.ros2.org/view/packaging/job/packaging_linux/ since Feb 10th, and try to compile https://github.com/ros-perception/image_common/tree/ros2 and https://github.com/ros-perception/image_pipeline/tree/ros2 after sourcing it, you'll get:
when trying to build |
This reverts commit 5954265.
This reverts commit 5954265. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette Sure, I'm not sure why this it occurred and why CI didn't catch it but I can look into it when I get the chance. |
* Revert "Address clang-tidy warnings (#47)" This reverts commit 602d4b1. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Revert "Refactor paths to use rcpputils filesystem helper (#46)" This reverts commit 5954265. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
The purpose of this refactor is to provide proper path support for both Linux and Windows systems. The previous implementation hard codes forward slashes which are not the convention on Windows systems. Using the filesystem helper in
rcpputils
resolves this.Using
rcpputils
pulls in the dependency onrcutils
for this package as well.I didn't change on the return signatures for the methods to avoid breaking any previous workflows.
Resolves #45
Signed-off-by: Anas Abou Allaban allabana@amazon.com