Revert 46 #48
Merged
Revert 46 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
force-pushed
the
revert-46
branch
from
b83722e
to
1240d39
Compare
|
Strange, ok yeah let’s revert. |
Blast545
pushed a commit
that referenced
this pull request
May 6, 2020
* Revert "Address clang-tidy warnings (#47)" This reverts commit 602d4b1. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Revert "Refactor paths to use rcpputils filesystem helper (#46)" This reverts commit 5954265. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes that went in as part of #46, but seem to be causing the Linux packaging jobs to not work properly. See #46 (comment) for details.
CC @piraka9011 @wjwwood