Add quality declaration ament_index_python #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
|
New changes to match new format based on REP-2004 |
brawner
suggested changes
Apr 28, 2020
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
brawner
reviewed
Apr 29, 2020
ahcorde
requested changes
Apr 29, 2020
ahcorde
requested changes
Apr 29, 2020
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
brawner
reviewed
Apr 30, 2020
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
brawner
approved these changes
May 1, 2020
Blast545
added a commit
that referenced
this pull request
May 6, 2020
* Add first draft quality declaration ament_index_python * Reformat to match new REP-2004 style * Remove extra empty lines * Remove specific version from qd * Fix formatting issue * Fix ABI stability description * Fix typo * Reformat performance section * Add public API testing results * Add review feedback * Add README.md with link Quality declaration * Change coverage link, fixed number * Add API declaration * Reformat with review feedback * Extend README description Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quality declaration for ament_index_python as described in the proposed REP-2004 (see ros-infrastructure/rep#218).
This declaration is aspirational, in that it states things which aren't currently true, but we plan to do soon so we can get it up to the highest level. (EDIT: this was merged with the current state of the ament_index_python)
Checklist in #49 can be checked first to sort out missing parts of the declaration.
Signed-off-by: Jorge Perez jjperez@ekumenlabs.com