Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ament_export_include_directories and ament_export_libraries #81

Merged
merged 1 commit into from Nov 30, 2021
Merged

Remove ament_export_include_directories and ament_export_libraries #81

merged 1 commit into from Nov 30, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Nov 29, 2021

Part of ament/ament_cmake#365

Remove ament_export_include_directories() and ament_export_libraries() because they're redundant with ament_export_targets().

@sloretz
Remove ament_export_include_directories and ament_export_libraries
8a7a41a 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Nov 29, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Nov 29, 2021

CI (build: --packages-above-and-dependencies ament_index_cpp test: --packages-select ament_index_cpp)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

audrow
audrow approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@sloretz sloretz merged commit aa774fe into master Nov 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the redundant_ament_export branch November 30, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @audrow