Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only append search paths on first PackageNotFound #91

Merged
merged 1 commit into from Mar 25, 2024

Conversation

lucasw
Copy link
Contributor

@lucasw lucasw commented Dec 17, 2023

I played a ros bag and got more than ten package not found warnings which took up a lot of lines of terminal output:

Ignoring a topic '/fmu/out/vehicle_status', reason: package 'px4_msgs' not found, searching: [/home/lucasw/ros/ros2_rolling/install/rqt_bag_plugins, /home/lucasw/ros/ros2_rolling/install/rosbag2, /home/lucasw/ros/ros2_rolling/install/rosbag2_storage_default_plugins, ...

Only the first instance was useful if I were to inspect the path output (though even printing out one complete set takes many lines of wrapped output), so limiting that here, it prints the first one fully then is more concise:

...
/home/lucasw/ros/ros2_rolling/install/ament_flake8, /home/lucasw/ros/ros2_rolling/install/ament_copyright, /home/lucasw/ros/ros2_rolling/install/ament_lint, /home/lucasw/ros/ros2_rolling/install/ament_index_python, /home/lucasw/ros/ros2_rolling/install/ament_index_cpp, /home/lucasw/ros/ros2_rolling/install/ament_cpplint, /home/lucasw/ros/ros2_rolling/install/ament_cppcheck, /home/lucasw/ros/ros2_rolling/install/ament_clang_tidy, /home/lucasw/ros/ros2_rolling/install/ament_clang_format].
[WARN] [1702825347.983349419] [rosbag2_player]: Ignoring a topic '/fmu/out/vehicle_odometry', reason: package 'px4_msgs' not found.
[WARN] [1702825347.983974247] [rosbag2_player]: Ignoring a topic '/fmu/out/vehicle_local_position', reason: package 'px4_msgs' not found.
[WARN] [1702825347.984591679] [rosbag2_player]: Ignoring a topic '/fmu/out/failsafe_flags', reason: package 'px4_msgs' not found.
[WARN] [1702825347.985206149] [rosbag2_player]: Ignoring a topic '/fmu/out/timesync_status', reason: package 'px4_msgs' not found.
[WARN] [1702825347.985826904] [rosbag2_player]: Ignoring a topic '/fmu/out/vehicle_control_mode', reason: package 'px4_msgs' not found.

Signed-off-by: Lucas Walter <wsacul@gmail.com>
@lucasw lucasw force-pushed the package_not_found_less_verbose branch from 6b16b50 to c9aac26 Compare December 17, 2023 15:14
@quarkytale
Copy link

quarkytale commented Mar 22, 2024

Don't see any major problems with this one. But a thought, the printed lines are for separate packages missing px4_msgs, if we remove the other lines but keep only one folks might disregard it if that package isn't relevant for their usecase?

Oh my bad this is just removing the appended paths!

@quarkytale
Copy link

quarkytale commented Mar 22, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@quarkytale
Copy link

Test failures are unrelated, getting this in!

@quarkytale quarkytale merged commit 327a38f into ament:rolling Mar 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants