Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore flake8 W504 #110

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Ignore flake8 W504 #110

merged 1 commit into from
Oct 25, 2018

Conversation

jacobperron
Copy link
Contributor

@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Oct 24, 2018
@jacobperron
Copy link
Contributor Author

Specifically, this ignores "line break after binary operator".

@jacobperron
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron
Copy link
Contributor Author

jacobperron commented Oct 25, 2018 •
edited

Looks like W605 "invalid escape sequence" is affecting us. It was also introduced in flake8 3.6 (using pycodestyle 2.4). Seems like most, of the warnings are due to regex's and can be resolved by using raw strings. We can go forward and fix the warnings in the affected packages or add another ignore here.

It does not appear that W606 or E252 (also new in pycodestyle 2.4) are causing any issues.

@dirk-thomas
Copy link
Contributor

If it is only in a few cases I would rather lean towards addressing them.

@jacobperron jacobperron merged commit c2cd5d6 into master Oct 25, 2018
@jacobperron jacobperron removed the in progress Actively being worked on (Kanban column) label Oct 25, 2018
@jacobperron jacobperron deleted the jacob/flake8_ignore_w504 branch October 25, 2018 16:53
@dirk-thomas dirk-thomas mentioned this pull request Nov 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @dirk-thomas