require latest uncrustify version from source

[tfoote]

We need the latest version 0.61. This should be documented in our install instructions: https://github.com/ros2/examples/wiki as well as in our CI jobs.

[tfoote]

Actually we need features more recent than the most recent 0.61, only in trunk.

Including but not limited to:

'string_replace_tab_chars'
'disable_processing_cmt'
'enable_processing_cmt'
'indent_class_on_colon'
'indent_shift'
'indent_min_vbrace_open'
'indent_vbrace_open_on_tabstop'
'sp_after_mdatype_commas'
'sp_before_mdatype_commas'
'sp_between_mdatype_commas'
'sp_cmt_cpp_doxygen'
'sp_between_new_paren'
'nl_after_label_colon'

Upstream source is here:
https://github.com/bengardner/uncrustify

[tfoote]

We need >0.61 We'll create an ament package to build the newest version and make it available on all 3 platforms.

[dirk-thomas]

I have forked the uncrustify repo (https://github.com/ament/uncrustify) and created a package.xml as well as CMakeLists.txt file to invoke configure && make for the package and install the binary in the bin folder.

The referenced PR will add the new repo to the ros2.repos file.

The latest test results (using this custom repos list) show that the uncrustify checks do pass now: http://54.183.26.131:8080/view/ros2/job/ros2_batch_ci_osx/88/testReport/

I could not yet get it to work on Windows. But the PR should be merged to make it work on the other platforms. I will continue to try to build it on Windows...

[dirk-thomas]

Waiting on Windows build to confirm that the latest changes (ament/uncrustify@96f42bc) actually make the uncrustify tests pass on Windows (ros2/ros2#34 (comment)).

[dirk-thomas]

After more debugging the latest build (http://54.183.26.131:8080/view/ros2/job/ros2_batch_ci_windows/166/) actually builds uncrustify successfully. The corresponding tests still fail but it looks like it is unrelated to the uncrustify binary itself.