Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Windows unit test results with Linux #34

Closed
2 tasks
wjwwood opened this issue Mar 31, 2015 · 5 comments
Closed
2 tasks

Compare Windows unit test results with Linux #34

wjwwood opened this issue Mar 31, 2015 · 5 comments
Assignees

Comments

@wjwwood
Copy link
Member

wjwwood commented Mar 31, 2015

Depends on #21

AC:

  • either equal test count or
  • different test count with rational differences
@dirk-thomas
Copy link
Member

  • clang-format missing
  • uncrustify missing
  • failing PEP8 test but not on Linux?

@tfoote tfoote added the ready Work is about to start (Kanban column) label Apr 14, 2015
@wjwwood
Copy link
Member Author

wjwwood commented Apr 15, 2015

ros2/rmw_connext#20

@dirk-thomas
Copy link
Member

I have updated the uncrustify wrapper package to work on windows (supposingly): ament/uncrustify@96f42bc

@wjwwood Currently Visual Studio on the Windows slave does not work anymore. Once this is fixed please trigger another build to check if it makes the uncrustify tests pass.

@dirk-thomas
Copy link
Member

All uncrustify tests: passing

@gerkey gerkey added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Apr 21, 2015
@wjwwood
Copy link
Member Author

wjwwood commented Jun 16, 2015

Linux and Windows now have the same number of tests (530):

There are some skipped tests and failing tests on Windows, but we have the same number at least. I scan over the tests and it appears that all of the failing tests on Windows are present on Linux and that there is not any linux only or windows only tests. Closing this, please comment if you see a problem.

@wjwwood wjwwood closed this as completed Jun 16, 2015
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants