Increase timeout for cppcheck runs. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms the cppcheck for the test_rclcpp package is hitting the timeout. Bumping the timeout on those platforms shows that the build takes about 130 seconds. So 180 should be sufficient room to grow without raising it too high. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
|
CI run with just Fast-RTPS. Build up to test_rclcpp and run just the cppcheck test for test_rclcpp
Edit: I forgot that test_rclcpp is one of the packages currently affected by API changes. Will wait to CI this until ros2/system_tests#423 lands |
sloretz
approved these changes
Apr 14, 2020
dirk-thomas
approved these changes
Apr 14, 2020
|
CI is yellow with known warnings on master. Going ahead and merging. |
delete-merged-branch
bot
deleted the
nuclearsandwich/ament-cppcheck-timeout
branch
|
I actually messed this up. macOS is still timing out at 180s. It's even in the CI output above and I didn't see it past the scrolloff. First step is figuring out how long its taking on macOS and trying to figure out why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms the cppcheck for the test_rclcpp package is hitting
the timeout. Bumping the timeout on those platforms shows that the build
takes about 130 seconds. So 180 should be sufficient room to grow
without raising it too high.