Make CMake linter line length configurable #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott K Logan <logans@cottsay.net>
mm318
approved these changes
Jan 26, 2021
|
Signed-off-by: Miaofei <miaofei@amazon.com>
|
Retrying CI after merging latest
|
|
Retrying macOS CI:
EDIT: Unstable test failure related to ros2/rclpy#666, unrelated to this change. |
mm318
reviewed
Jan 26, 2021
| @@ -70,6 +73,8 @@ def main(argv=sys.argv[1:]): | |||
| # invoke cmake lint | |||
| cmakelint._lint_state.config = cmakelint._DEFAULT_CMAKELINTRC | |||
| cmakelint._lint_state.SetFilters(args.filters) | |||
| if args.linelength is not None: | |||
| cmakelint._lint_state.SetLineLength(str(args.linelength)) | |||
There was a problem hiding this comment.
Kind of strange that we're casting from int to str and then back to int, but it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modeled as much of the change as I could after what was done in the upstream code: https://github.com/richq/cmake-lint/commits/master
After that, I just added an arg to our
main.pyto expose it from our CMake logic like the other linters that can take a line length argument.