Allow to configure language in cppcheck with a global var #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
May 11, 2020
ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
May 12, 2020
ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
May 12, 2020
ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
May 22, 2020
ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
May 22, 2020
ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
@dirk-thomas What is the process to merge this PR? I checked that this is running lint_cmake and copyright. There is no package upstream that uses this option yet (I plan to use this option in tf2). Should I run CI up to ament_lint and run these two tests? |
|
CI builds testing the touched package seems to be enough in this case (since the patch shouldn't have any effect on existing packages). |
|
Running CI up-to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure language in cppcheck with a global var
Signed-off-by: ahcorde ahcorde@gmail.com