Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure language in cppcheck with a global var #239

Merged
merged 10 commits into from
May 25, 2020
Merged

Allow to configure language in cppcheck with a global var #239

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
105e07d
Allow to configure language in cppcheck with a global var
ahcorde May 11, 2020
d751f08
Added feedback
ahcorde May 12, 2020
ca7dbae
added feedback
ahcorde May 12, 2020
2a7b2d1
added feedback
ahcorde May 12, 2020
6a6e4d1
Added feedback
ahcorde May 13, 2020
4ee41f3
Merge branch 'master' into ahcorde/cppcheck_global_language
ahcorde May 15, 2020
5388cb6
Fixed cpplint
ahcorde May 21, 2020
6786139
Print language message if it's not empty
ahcorde May 22, 2020
afe25a9
fixed language message
ahcorde May 22, 2020
df8ccfd
Improved comment
ahcorde May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ if(_source_files)
list(APPEND _all_include_dirs ${ament_cmake_cppcheck_ADDITIONAL_INCLUDE_DIRS})
endif()

# Language
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved
set(_language "")
if(DEFINED ament_cmake_cppcheck_ADDITIONAL_LANGUAGE)
list(APPEND _language ${ament_cmake_cppcheck_ADDITIONAL_LANGUAGE})
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved
endif()
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved

# BUILDSYSTEM_TARGETS only supported in CMake >= 3.7
if(NOT CMAKE_VERSION VERSION_LESS "3.7.0")
get_directory_property(_build_targets DIRECTORY ${PROJECT_SOURCE_DIR} BUILDSYSTEM_TARGETS)
Expand Down Expand Up @@ -64,5 +70,6 @@ if(_source_files)
endif()

message(STATUS "Configured cppcheck include dirs: ${_all_include_dirs}")
ament_cppcheck(INCLUDE_DIRS ${_all_include_dirs})
message(STATUS "Configured cppcheck language : ${_language}")
ament_cppcheck(LANGUAGE ${_language} INCLUDE_DIRS ${_all_include_dirs})
endif()