parse LANGUAGE argument case insensitive #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
jacobperron
approved these changes
Jun 18, 2020
Karsten1987
added a commit
that referenced
this pull request
Jun 18, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
added a commit
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uncrustify and cppcheck both accept a language specifier, yet both are taking the argument with different cases (
c++vsC++).At least on ament cmake side, we should accept both values and convert them to the appropriate case.
I am not sure how cmake works with backporting, but ideally that change would land in Foxy as well.