Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added bsd 2 clause simplified license to ament_copyright #267

Merged
merged 2 commits into from
Sep 11, 2020
Merged

added bsd 2 clause simplified license to ament_copyright #267

merged 2 commits into from
Sep 11, 2020

Conversation

flynneva
Copy link
Contributor

No description provided.

@flynneva
added bsd 2 clause simplified license to ament_copyright
0903875 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
Copy link
Contributor Author

@dirk-thomas, bump.

this is just a simple PR to add another license to this tool.
required for one of the packages I manage to pass its CI.

could we get someone assigned to review this?

@clalancette clalancette self-requested a review September 11, 2020 19:53
@clalancette clalancette self-assigned this Sep 11, 2020
clalancette
clalancette requested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing to fix, then this will be ready for CI/merge.

ament_copyright/ament_copyright/template/bsd_2clause_contributing.txt Outdated Show resolved Hide resolved
@flynneva
removed blank line
62ca354 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
clalancette
clalancette approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating. Running CI on this package next.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit b942f78 into ament:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flynneva @clalancette