Add SPDX identifiers to the licenses. #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we can use them at a higher layer. Note that the SPDX identifier for "BSD License 2.0" is made up, since that license is also made up. We eventually need to remove it, but some of the core packages still depend on it (and really should be switched over to BSD-3-Clause). Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Could be worth adding a comment mentioning these should be SPDX identifiers? Would be useful to be explicit in case people want to add new licenses! |
The variable it gets put into is named 'spdx', which seems pretty clear to me. But maybe it is worthwhile to point to the URL where I got these; I'll add that. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Full CI (since basically everything depends on this package):
|
|
The only failures are in mypy, which is a known issue right now. |
|
Approved, and no new test failures. Going ahead and merging. |
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we can use them at a higher layer. Note that the
SPDX identifier for "BSD License 2.0" is made up, since that
license is also made up. We eventually need to remove it,
but some of the core packages still depend on it (and really
should be switched over to BSD-3-Clause).
Signed-off-by: Chris Lalancette clalancette@openrobotics.org