Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow C-style casts in c code #32

Merged
merged 1 commit into from
Oct 19, 2015
Merged

allow C-style casts in c code #32

merged 1 commit into from
Oct 19, 2015

Conversation

dirk-thomas
Copy link
Contributor

No description provided.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Oct 15, 2015
@dirk-thomas dirk-thomas self-assigned this Oct 15, 2015
@@ -5432,6 +5432,10 @@ def CheckCStyleCast(filename, clean_lines, linenum, cast_type, pattern, error):
'All parameters should be named in a function')
return True

# Don't warn in C files about C-style casts
if os.path.splitext(filename)[1] in ['.c', '.cc', '.h', '.hh']:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.cc and .hh are for C++ aren't they?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@esteve
Copy link
Contributor

esteve commented Oct 15, 2015

+1

1 similar comment
@wjwwood
Copy link
Contributor

wjwwood commented Oct 15, 2015

+1

dirk-thomas added a commit that referenced this pull request Oct 19, 2015
@dirk-thomas dirk-thomas merged commit 3a4c19a into master Oct 19, 2015
@dirk-thomas dirk-thomas deleted the cpplint_c_style_casts branch October 19, 2015 22:24
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Oct 19, 2015
kenji-miyake referenced this pull request in kenji-miyake/ament_lint Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants