ignore cpplint runtime/int error #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review. |
|
Wouldn't it be better to actually change |
|
That would be a good alternative. Could you work on creating PRs for that instead? Then we don't have to ignore this cpplint error. |
|
Is there a log of cpplint on the buildfarm to see the warnings? |
|
No, I only ran the tests with ament_cmake_cpplint added as a default linter locally. |
3 tasks
|
We'll merge this as is. And open a ticket to clean up the usage and let us revert this later. |
dirk-thomas
added a commit
that referenced
this pull request
Oct 27, 2015
ignore cpplint runtime/int error
kenji-miyake
referenced
this pull request
in kenji-miyake/ament_lint
Oct 20, 2021
ignore cpplint runtime/int error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.