Increase the ament_cmake_copyright default timeout. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add one minute so that Windows Debug won't fail as often. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
aprotyas
approved these changes
Feb 28, 2022
|
Linux aarch64 is unstable, but that is due to other (known) reasons. The failures in Windows and Windows Debug have variously been in the nightlies. Regardless, it seems unlikely that any of that was caused by this PR, so going ahead and merging this one. |
delete-merged-branch
bot
deleted the
clalancette/increase-copyright-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one minute so that Windows Debug won't fail as often.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
If you look at https://ci.ros2.org/view/nightly/job/nightly_win_deb/2282/consoleFull and search for:
You'll see that the copyright check timed out. If you look at an earlier job (like https://ci.ros2.org/view/nightly/job/nightly_win_deb/2277/consoleFull), and search for the same line, you'll see that the job completed in just under 120 seconds. Since we are so close to the margin here, bump up the timeout to 200 seconds, which won't have an appreciable difference to our CI but should make it a lot more reliable on Windows Debug.