remove result type extension from testsuite name #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review. |
|
+1, it would be nice to reuse this snippet since it's identical in 9 places including several lines before ad after the changes, but they don't have a common dependency related to linting at the moment so it's not worth adding a dependency. But if there's more in the future it might be worth adding somewhere to contain similar common methods. . |
dirk-thomas
added a commit
that referenced
this pull request
Nov 23, 2015
remove result type extension from testsuite name
kenji-miyake
referenced
this pull request
in kenji-miyake/ament_lint
Oct 20, 2021
remove result type extension from testsuite name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #27 added the result type extension to make Jenkins happy all the testsuite names had the extra extension in their name. This added an unnecessary level to the hierarchy.
Before: http://ci.ros2.org/job/ros2_batch_ci_linux/621/testReport/ament_clang_format.lint_cmake/
After: http://ci.ros2.org/job/ros2_batch_ci_linux/622/testReport/ament_clang_format/lint_cmake/