ignore space after a semi colon #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
in progress
|
lgtm |
wjwwood
added a commit
that referenced
this pull request
Dec 11, 2015
ignore space after a semi colon
kenji-miyake
referenced
this pull request
in kenji-miyake/ament_lint
Oct 20, 2021
ignore space after a semi colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it makes sense to not have whitespace after a semicolon, e.g.
if (true) {return foo;}. Other times it is appropriate, e.g.#define FOO(arg) bar(); foo(arg); baz();. Sinceuncrustifycannot know when it is appropriate I propose we tell it to ignore this rule and we can leave this to the developer's discretion. Since it is ignored, existing code should not be affected, but I could go through and find places it really should not have space after it, but I don't think it matters that much.