Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ament_xmllint) add extensions argument #456

Merged
merged 2 commits into from
Oct 24, 2023
Merged

(ament_xmllint) add extensions argument #456

merged 2 commits into from
Oct 24, 2023

Conversation

MatthijsBurgh
Copy link
Contributor

Fixes #455

@MatthijsBurgh
(ament_xmllint) add extensions argument
2d8ba57 
Signed-off-by: Matthijs van der Burgh <MatthijsBurgh@outlook.com>
@MatthijsBurgh
Copy link
Contributor Author

friendly ping @mjeronimo

Or maybe @clalancette @rodericktaylor?

clalancette
clalancette requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is a fine change to have. I've left some feedback for improvement.

ament_xmllint/ament_xmllint/main.py Outdated Show resolved Hide resolved
ament_xmllint/ament_xmllint/main.py Outdated Show resolved Hide resolved
ament_xmllint/ament_xmllint/main.py Show resolved Hide resolved
@MatthijsBurgh @clalancette
(ament_xmllint) small changes to argparser help msgs
eebdb77 
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
clalancette
clalancette approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks. I'll run CI on it next.

@clalancette
Copy link
Contributor

clalancette commented Oct 23, 2023 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 7a5876e into ament:rolling Oct 24, 2023
3 checks passed
wuisky pushed a commit to wuisky/ament_lint that referenced this pull request Feb 7, 2024
@MatthijsBurgh @clalancette @wuisky
(ament_xmllint) add extensions argument (ament#456)
2b32969 
* (ament_xmllint) add extensions argument

Signed-off-by: Matthijs van der Burgh <MatthijsBurgh@outlook.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: WU MENGHUNG <wu.menghung@jp.panasonic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(ament_xmllint) add extension argument
2 participants
@MatthijsBurgh @clalancette