extend linter API to allow overriding the max line length #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if args.linelength != code_width: | ||
| # generate temporary config file with custom line length | ||
| temp_config = tempfile.NamedTemporaryFile('w') | ||
| temp_config.write(config_str + '\ncode_width=%d' % args.linelength) |
There was a problem hiding this comment.
This appends the config parameter, but does not remove the original if it's already set. Will that work correctly in that case?
There was a problem hiding this comment.
Yes, in an ini-like file the last value is the one being used.
|
+1 |
| code_width = int(re.split('[ \t#]', code_width, maxsplit=1)[0]) | ||
| if args.linelength != code_width: | ||
| # generate temporary config file with custom line length | ||
| temp_config = tempfile.NamedTemporaryFile('w') |
There was a problem hiding this comment.
https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile
Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later).
Fixed in #52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generators can't always ensure that the generated code stays within a specific maximum line length. So using this that setting can be overridden.