fix handling of --root #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
lint_generated_code
branch
from
4fa5e87
to
ae3b9ae
Compare
dirk-thomas
force-pushed
the
lint_generated_code
branch
3 times, most recently
from
4da08b6
to
79166c4
Compare
dirk-thomas
force-pushed
the
lint_generated_code
branch
from
79166c4
to
2a12c4f
Compare
dirk-thomas
force-pushed
the
lint_generated_code
branch
from
1cfe182
to
92bf533
Compare
|
lgtm +1 |
|
Added 45e5812 to fix an undefined variable in case of early exception (e.g. when passing not existing file names). |
kenji-miyake
referenced
this pull request
in kenji-miyake/ament_lint
Oct 20, 2021
fix handling of --root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
RepositoryNamedoes not start with the prefix also try if the fullfilenamepath does. This is the case when a custom absolute--rootis being passed.Fixes e.g. http://ci.ros2.org/job/ci_linux/1272/testReport/junit/test_communication/cpplint_rosidl_generated_cpp/build_header_guard__5____home_rosbuild_ci_scripts_ws_build_test_communication_rosidl_generator_cpp_test_communication_msg_dynamic_array_primitives__struct_hpp_303_/
After: http://ci.ros2.org/job/ci_linux/1279/
Connect to ros2/rosidl#130