update style to satisfy new flake8 plugins #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,5 @@ | |||
| [flake8] | |||
| ignore = D100,D101,D102,D103,D104,D105,D203,D212,D404 | |||
| ignore = C816,D100,D101,D102,D103,D104,D105,D203,D212,D404 | |||
There was a problem hiding this comment.
is this ignored because it conflicts with another enforced rule (C815?) ?
There was a problem hiding this comment.
No, C816 is a suggestion specific to Python 3.6+. Since we are targeting only 3.5 we can't use the suggested style.
dhood
reviewed
Aug 29, 2017
| license = licenses[args.add_missing[1]] | ||
| add_missing_header(file_descriptors, name, license, args.verbose) | ||
| add_missing_header( | ||
| file_descriptors, name, licenses[args.add_missing[1]], args.verbose) |
There was a problem hiding this comment.
what was the error we're addressing here? if it's that we don't want 'wasteful' variables I don't think we should enforce that across the whole codebase as a general rule, because it's usually done for improved readability. but it may have been for another reason.
There was a problem hiding this comment.
license is a built-in in Python and should not be used as a variable name.
dirk-thomas
force-pushed
the
flake8_plugins
branch
2 times, most recently
from
eb7feb6
to
9652e49
Compare
dirk-thomas
force-pushed
the
flake8_plugins
branch
from
9652e49
to
332b80e
Compare
kenji-miyake
pushed a commit
to kenji-miyake/ament_lint
that referenced
this pull request
Oct 20, 2021
update style to satisfy new flake8 plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to ros2/ci#98.