Add I202 to the list of ignored flake8 errors. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I202 warns about newlines between groups of imports in python. A recent change in flake8 (PyCQA/flake8-import-order@37dafcc) made this start showing up in ROS2. Since we use whitespace between imports in lots of places in ROS2, disable this warning, which should get rid of this error almost everywhere. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
dirk-thomas
approved these changes
Nov 7, 2017
|
Even though the macOS build isn't finished, I'm going to merge this to unblock Windows from constantly failing. I'll deal with any fallout from macOS if it has problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not quite ready for review, opening for visibility)
I202 warns about newlines between groups of imports in python.
A recent change in flake8
(PyCQA/flake8-import-order@37dafcc)
made this start showing up in ROS2. Since we use whitespace
between imports in lots of places in ROS2, disable this
warning, which should get rid of this error almost everywhere.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
CI:
connects to ros2/build_farmer#67