Increase cpplint timeout #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wjwwood FYI |
mikaelarguedas
added
in review
dirk-thomas
reviewed
Dec 7, 2017
| @@ -24,13 +24,15 @@ | |||
| # :type MAX_LINE_LENGTH: integer | |||
| # :param ROOT: override the --root option of cpplint | |||
| # :type ROOT: string | |||
| # :param TIMEOUT: the test timeout in seconds, default: 60 | |||
There was a problem hiding this comment.
The documented default value doesn't match the implementation.
dirk-thomas
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpplint on arm is hitting the 60-second limit for some packages (http://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_release/254/).
This exposes the timeout argument and sets it to 120 by default so that we're safe in the future.
Looking at the time of all linters, this seems to be the only one that needs to be bumped. But I can propagate it to the other linters if we want to have the same set of parameters everywhere.