Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MIT license templates. #105

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Adding MIT license templates. #105

merged 2 commits into from
Jul 30, 2018

Conversation

JWhitleyWork
Copy link

No description provided.

@esteve esteve added the in review Waiting for review (Kanban column) label Jul 29, 2018
@mikaelarguedas
Copy link
Contributor

LGTM, tested using:

$ ros2 pkg create foobarmit --license MIT --cpp-library-name foobarmitlib

pasting the ogre license header below at the beginning of include/foobarmit/visibility_control.h, include/foobarmit/foobarmitlib.hpp.

Ogre license header
// This source file is part of OGRE
// (Object-oriented Graphics Rendering Engine)
// For the latest info, see http://www.ogre3d.org/
//
// Copyright (c) 2000-2014 Torus Knot Software Ltd
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

Run ament copyright on it:

$ ament_copyright ./foobarmit/
foobarmit/src/foobarmitlib.cpp: could not find copyright notice
1 errors, checked 3 files

Adding the license header to src/foobarmitlib.cpp as well:

$ ament_copyright ./foobarmit/
No errors, checked 3 files

@mikaelarguedas
Copy link
Contributor

mikaelarguedas commented Jul 30, 2018

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

CI on ament_copyright and some BSD and apache packages (no MIT packages in the ROS2 repos ATM)

Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, merging

@mikaelarguedas mikaelarguedas merged commit 5a0746a into ament:master Jul 30, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants