Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declare pytest markers #164

Merged
merged 2 commits into from
Jul 30, 2019
Merged

declare pytest markers #164

merged 2 commits into from
Jul 30, 2019

Conversation

dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas commented Jul 29, 2019 •
edited
Loading

Fixes #145.

The new package ament_lint contains the registration for the linter marker. In the future it could also be used for some common API across linters (see #157).

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (unrelated failures)

@dirk-thomas
declare pytest markers
d1e9203 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
add markers to ament_xmllint tests
00a9aa4 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels Jul 29, 2019
@dirk-thomas dirk-thomas self-assigned this Jul 29, 2019
@dirk-thomas dirk-thomas mentioned this pull request Jul 29, 2019
Closed
emersonknapp
emersonknapp approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for making this change - the warnings were not blocking anything but it'll be nice to not see them.

hidmic
hidmic approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Just curious, are we using these markers consistently throughout all ROS 2 repos? Should we?

@dirk-thomas
Copy link
Contributor Author

are we using these markers consistently throughout all ROS 2 repos?

Yes, we are.

Should we?

If there are cases where we don't: yes, we should.

@dirk-thomas dirk-thomas merged commit a5642d5 into master Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/pytest-markers branch July 30, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@hidmic hidmic hidmic approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pytest warnings about unknown marks
3 participants
@dirk-thomas @emersonknapp @hidmic