Windows Support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current master is missing |
|
@esteve I fixed master and rebased this branch, please pull. |
This was referenced Mar 14, 2015
|
I've ticked the todo items above, I think we should merge this and fix those in separate prs. |
| @@ -23,7 +23,7 @@ def get_environment_hook_template_path(name): | |||
|
|
|||
|
|
|||
| def get_package_level_template_names(): | |||
| return ['local_setup.%s.in' % ext for ext in ['bash', 'sh', 'zsh']] | |||
| return ['local_setup.%s.in' % ext for ext in ['bash', 'sh', 'zsh', 'bat']] | |||
There was a problem hiding this comment.
Nitpick: insert in alphabetical order. Same two more times below.
|
+1 |
|
lgtm |
This does not include the prefix level setup.bat template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Windows by providing and exposing
.batversions of the.shprefix level and package levellocal_setupandsetuptemplate files.There is still work to be done here:
The prefix levelConvert prefix level setup.bat file to batch #8setup.bat.instill contains shell code and needs to be converted to batchThe prefix levelChange sorting of environment hooks #7local_setup.bat.instill does not order environment hooks by file nameThe isolated install'sTest isolated install on Windows ros2/ros2#17local_setup.bat.inneeds to be testedConnects to ros2/ros2#9