Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Build shared libraries by default, but honor BUILD_SHARED_LIBS #128

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions ament_tools/build_types/ament_cmake.py
Expand Up @@ -50,6 +50,12 @@ def argument_preprocessor(self, args):
# This requires special handling or argparse will complain about
# unrecognized options.
args, cmake_args = extract_argument_group(args, '--ament-cmake-args')

# Build shared libraries by default unless -DBUILD_SHARED_LIBS is passed
# as an argument to CMake
if not any([cmake_arg.startswith('-DBUILD_SHARED_LIBS=') for cmake_arg in cmake_args]):
cmake_args.append('-DBUILD_SHARED_LIBS=ON')

extras = {
'ament_cmake_args': cmake_args,
}
Expand Down
6 changes: 6 additions & 0 deletions ament_tools/build_types/cmake.py
Expand Up @@ -77,6 +77,12 @@ def argument_preprocessor(self, args):
# unrecognized options.
args, cmake_args = extract_argument_group(args, '--cmake-args')
args, ctest_args = extract_argument_group(args, '--ctest-args')

# Build shared libraries by default unless -DBUILD_SHARED_LIBS is passed
# as an argument to CMake
if not any([cmake_arg.startswith('-DBUILD_SHARED_LIBS=') for cmake_arg in cmake_args]):
cmake_args.append('-DBUILD_SHARED_LIBS=ON')

extras = {
'cmake_args': cmake_args,
'ctest_args': ctest_args,
Expand Down