Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

add --ignore-return-codes option to ament test #141

Merged
merged 2 commits into from
Mar 15, 2017
Merged

add --ignore-return-codes option to ament test #141

merged 2 commits into from
Mar 15, 2017

Conversation

gerkey
Copy link
Contributor

@gerkey gerkey commented Mar 14, 2017

Implements proposal from #140.

@gerkey gerkey added the in progress Actively being worked on (Kanban column) label Mar 14, 2017
@gerkey gerkey mentioned this pull request Mar 14, 2017
Merged
@gerkey
Copy link
Contributor Author

gerkey commented Mar 14, 2017

ros2/ci#36 uses the new option.

CI jobs using the new option:

http://ci.ros2.org/job/ci_osx/1778/
http://ci.ros2.org/job/ci_windows/2359/
http://ci.ros2.org/job/ci_linux/2320/

@gerkey
Copy link
Contributor Author

gerkey commented Mar 14, 2017

Let's try that again:

http://ci.ros2.org/job/ci_linux/2321/
http://ci.ros2.org/job/ci_osx/1779/
http://ci.ros2.org/job/ci_windows/2361/

wjwwood
wjwwood approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gerkey
Copy link
Contributor Author

gerkey commented Mar 15, 2017

Linux and OSX look good. The Windows build seems have gotten lost in the weeds, having run almost 7 hours. I killed it and started a new one:

http://ci.ros2.org/job/ci_windows/2370/

@gerkey gerkey merged commit c08f343 into master Mar 15, 2017
@gerkey gerkey deleted the add_ignore_return_codes branch March 15, 2017 16:18
@gerkey gerkey removed the in progress Actively being worked on (Kanban column) label Mar 15, 2017
@gerkey gerkey mentioned this pull request Mar 15, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gerkey @wjwwood