updated ament_cmake's on_test for Windows

[wjwwood]

This pull request changes the on_test code for the ament_cmake build type so that it can run tests on Windows using msbuild and the RUN_TESTS VS project.

Ready for review.

Fixes #23

[dirk-thomas]

run test should be plural and I would suggest to quote the build type:

self.warn("Could not run tests for 'ament_cmake' package because it "
          "has no 'test' target")

It could also following the new 100 chars wrapping rule instead of at 80 chars. (Same below)

[wjwwood]

It's too long for 100 char without wrapping.

[dirk-thomas]

The osrf_pycommon package does not pass the syntax check with Python 2.x. Should we remove Python 2.x from the .travis file?

[tfoote]

Looks like the right behavior.

[dirk-thomas]

Now the windows job (http://54.183.26.131:8080/view/ros2/job/ros2_batch_ci_windows/82/console) fails when trying to run the test command. The following Python code needs to handle Visual Studio:

ament_tools/ament_tools/build_types/cmake_common.py

Line 30 in 1d78c5e

output = subprocess.check_output([MAKE_EXECUTABLE, '-pn'], cwd=path)

[wjwwood]

Now the windows job (http://54.183.26.131:8080/view/ros2/job/ros2_batch_ci_windows/82/console) fails when trying to run the test command.

That's the original error I believe, the Windows job is not setup to test this branch. I'll change the Windows job to use this branch.

[wjwwood]

I've got a job running which is using this pr: http://54.183.26.131:8080/job/ros2_batch_ci_windows/83/console We'll have to see if that works.

[wjwwood]

It now fails with:

CMake Error at cmake/ament_copyright.cmake:19 (message):
  ament_copyright() could not find program 'ament_copyright'
Call Stack (most recent call first):
  CMakeLists.txt:25 (ament_copyright)


-- Configuring incomplete, errors occurred!

I thought @tfoote solved that, did you make a pull request for that @tfoote?

[wjwwood]

The osrf_pycommon package does not pass the syntax check with Python 2.x. Should we remove Python 2.x from the .travis file?

That was a connection timed out error (the pr version of the python 2.7 job passed), I retriggered the job.

We could remove the Python2 check in general though.

[wjwwood]

CI is passing now.

[wjwwood]

I'm going to merge this because I tested it locally, it passes the travis CI, and I believe the remaining error on the Windows batch job is unrelated.

[wjwwood]

I changed the job back to not try to change branches.

[dirk-thomas]

How do we want to address the pending comments?

[wjwwood]

Sorry, I forgot those, I'll update those comments about the wording in a follow on commit. For the one about the --build-tests flag, I'll remove the reference, but we should open another issue if we want to change the flags on the test* verbs.

[wjwwood]

I addressed the comments as well as I could in 24ddad5.

[dirk-thomas]

Great, thanks.