add --no-build option to test and test_pkg #32
Conversation
| @@ -46,6 +46,10 @@ def prepare_arguments(parser, args): | |||
| default=False, | |||
| help='Stop after tests with errors or failures', | |||
| ) | |||
| parser.add_argument( | |||
| '-n', '--no-build', dest='build_before_test', default=True, action='store_false', | |||
| help="assumes package is built, only running the tests" | |||
There was a problem hiding this comment.
To match other arguments I would suggest:
help='Skip building package, assuming it has been built before'
|
+1 |
1 similar comment
|
+1 |
wjwwood
force-pushed
the
test_option_no_build
branch
from
9fa9588
to
7b66409
Compare
|
Ok, I've pushed an entirely different commit which just adds a After building of course. |
|
@dirk-thomas @esteve @tfoote can I get a new review? |
wjwwood
force-pushed
the
test_option_no_build
branch
from
7b66409
to
0b71995
Compare
|
+1 |
1 similar comment
|
+1 |
|
+1 Do you have as specific build log where it rebuild stuff on the second run? That would indicate that some part in our build process is buggy and we might want to investigate that further... |
|
All of the current build farm builds do some rebuilding: http://54.183.26.131:8080/job/ros2_batch_ci_linux/13/consoleFull For example, if you search for |
add --no-build option to test and test_pkg
|
I opened a ticket to track this: ros2/ros2#40 I think it will take some time to figure out what is being done redundantly build to build, and to then dig into the potential causes of those items and find solutions. I don't think I have time to do it right now, but it might be something someone can pick up in their spare time. Even if there was no rebuilding build to build, these options are probably a good idea on the farm since it will skip the make check and the redundant install/install check. |
This option will skip trying to build the package before testing. This should really speed up our build farm jobs which are basically building twice for no reason. Most packages just do a quick build check and install check, but it still takes time. Others actually rebuild, for why I don't know, but it may be because the files get installed again and therefore the are touched.
@dirk-thomas @esteve @tfoote for review.