This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Use verb pattern #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as documentation about how to use them to extend the supported build types for ament_tools.
They now use the BuildType and BuildAction API's.
- Made everything verb agnostic - Changed the entry_point name - Moved the source for the ament_cmake build_type - Refactored discovery and loading of build_types out of the build_pkg verb module.
Also now uses build_type pattern. Expanded ament_cmake plugin to include testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor for the verb's to use the generalized "verb pattern" now in osrf_pycommon:
osrf/osrf_pycommon#6
This pull request also refactors
buildandbuild_pkgto use the concept of BuildType and BuildActions to define build workflows for differentbuild_type's.Todo:
osrf_pycommon's "verb pattern":buildbuild_pkglist_packagespackage_namepackage_versiontesttest_pkgBuildActionandBuildTypepattern:buildbuild_pkg