Set minimum criteria for system package #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some features in 1.5.X that I think we'll want to leverage. Also work around what I believe is a packaging bug in Ubuntu Eoan and newer. I'm not 100% certain, but I believe that libbenchmark_main doesn't work correctly when it's not a shared library. This means that right now, none of the supported platforms have an acceptable version of `benchmark` available as a system package. However, Fedora's package seems to work OK and I was able to confirm that this package behaves correctly in the presence of the system package. Signed-off-by: Scott K Logan <logans@cottsay.net>
|
Another packaging bug, this time in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1858127 |
Signed-off-by: Scott K Logan <logans@cottsay.net>
hidmic
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some features in 1.5.X that I think we'll want to leverage.
Also work around what I believe is a packaging bug in Ubuntu Eoan and newer. I'm not 100% certain, but I believe that libbenchmark_main doesn't work correctly when it's not a shared library.
https://bugs.launchpad.net/ubuntu/+source/benchmark/+bug/1887872
This means that right now, none of the supported platforms have an acceptable version of
benchmarkavailable as a system package.