Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade google benchmark from v1.5.1 to v1.5.2 to include QNX patch #9

Merged
merged 1 commit into from
Sep 29, 2020
Merged

upgrade google benchmark from v1.5.1 to v1.5.2 to include QNX patch #9

merged 1 commit into from
Sep 29, 2020

Conversation

asobhy-qnx
Copy link
Contributor

fixes #7 by clonning https://github.com/google/benchmark.git commit tag: 1302d2ce094a9753b0f81a81ea74c0fa71fae582
which includes a patch, google/benchmark#1010, that was pushed to google benchmark which allows it to cross compile for QNX

@asobhy-qnx asobhy-qnx changed the title change from grabbing an archive to clonning a git repo with commit ta… change from downloading an archive to clonning a git repo with commit ta… Sep 22, 2020
@asobhy-qnx
Copy link
Contributor Author

@dirk-thomas

@asobhy-qnx
Copy link
Contributor Author

@dirk-thomas what do you think about this one?

CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@asobhy-qnx asobhy-qnx closed this Sep 29, 2020
@asobhy-qnx asobhy-qnx reopened this Sep 29, 2020
@asobhy-qnx asobhy-qnx changed the title change from downloading an archive to clonning a git repo with commit ta… upgrade google benchmark from v1.5.1 to v1.5.2 to include QNX patch Sep 29, 2020
Signed-off-by: Ahmed Sobhy <asobhy@blackberry.com>
Copy link
Contributor

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the two patches still apply, this LGTM.

@dirk-thomas
Copy link

CI builds testing this package and above:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas merged commit a8fe69f into ament:main Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 1.5.1 does not include QNX patch
3 participants