This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Uncrustify vendor #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in review
|
merging this as is to get the release out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal set of changes to address ros2/rosdistro#96 (comment)
This will still build uncrustify on all platforms byut make sure we pull in our versions and not the upstream one.
I'll open a follow-up to make it an actual vendor package but it may not be done by bouncy release day.
@dirk-thomas As we are tracking official uncrustify upstream, I updated the link. Not sure what we should put in the
CPACK_PACKAGE_VENDORvariable though