Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom window.open settings #10

Merged
merged 2 commits into from
Apr 24, 2016
Merged

Conversation

amercier
Copy link
Owner

@amercier amercier commented Apr 24, 2016

This RB adds support for custom window.open settings:

PromiseWindow.open(url, {
  ... // width, height, etc.
  window: {
    scrollbars: false, // true by default
  }
});  

Fixes #9.


Warning: beware that most settings have been disabled in modern browsers, for accessibility reasons. As far as I know only scrollbars works as intended.


See window.open documentation on MDN for more details.

@amercier amercier self-assigned this Apr 24, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 98.261% when pulling eee7717 on more-options into 9c369e7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 98.261% when pulling 007f3fd on more-options into 9c369e7 on master.

@amercier amercier merged commit 2121527 into master Apr 24, 2016
@amercier amercier deleted the more-options branch April 24, 2016 01:00
@amercier
Copy link
Owner Author

Released in v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants