Fixed button title width bug #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Vortec4800. I know it's been a long time since you opened the PR, but I only now got some time to review it. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was running into a bug where changing the button title string after the initial layout would cause the button width to not recalculate, and either be too wide or too skinny. This happened most often in reusable table view cells that would redraw for different content, in my use-case the button could say "INSTALL" "DOWNLOAD" or "UPDATE" which require 3 different widths, and scrolling on the list it would get out of sync almost immediately.
Setting the title width back to zero on string didSet causes the width constant to be recalculated on the next layout cycle, which fixes the problem.