fix(plugins): include removeProps plugin only for production mode

americanexpress · Jun 17, 2021 · dfb83e2 · dfb83e2
1 parent 827be9a
commit dfb83e2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/__tests__/index.spec.js b/__tests__/index.spec.js
@@ -58,4 +58,14 @@ describe('babel-preset-amex', () => {
   it('allows options to be passed to plugins', () => {
     expect(preset({}, { 'preset-env': { exclude: ['@babel/plugin-transform-regenerator'] } })).toMatchSnapshot();
   });
+
+  it('in development mode, includes an array of plugins', () => {
+    const originalEnv = process.env;
+    process.env = { NODE_ENV: 'development' };
+
+    expect(preset().plugins).toEqual(expect.any(Array));
+    expect(preset().plugins.length).toEqual(4);
+
+    process.env = originalEnv;
+  });
 });
diff --git a/index.js b/index.js
@@ -25,6 +25,16 @@ const { browserList, legacyBrowserList } = require('./browserlist');
 module.exports = (api = {}, opts = {}) => {
   const serverOnly = opts.serverOnly || (api.env && api.env('server'));
   const isModern = opts.modern || (api.env && api.env('modern'));
+  const isProduction = process.env.NODE_ENV === 'production';
+  const plugins = [
+    syntaxDynamicImport,
+    proposalClassProperties,
+    exportDefaultFrom,
+    proposalOptionalChaining,
+  ];
+  if (isProduction) {
+    plugins.push(removePropTypes);
+  }
 
   const targets = {
     node: 'current',
@@ -53,12 +63,6 @@ module.exports = (api = {}, opts = {}) => {
         reactPresetOptions,
       ],
     ],
-    plugins: [
-      syntaxDynamicImport,
-      proposalClassProperties,
-      exportDefaultFrom,
-      proposalOptionalChaining,
-      removePropTypes,
-    ],
+    plugins,
   };
 };